Re: [PATCH hurd] build: Drop unused/unsubstituted config variables

[Luca Weiss]

I needed the patch for building with these commands: https://github.com/z3ntu/archhurd_packages_new/blob/master/hurd/PKGBUILD#L29-L58 . I didn't try to type them manually but used the tool from Arch Linux called makepkg where this issue occured. I initially posted the patch in the IRC like "this not pretty patch seems to fix it", so don't blame me too hard 😉 also, I have no idea what the initial problem was (imo the patch is just a workaround).

Luca

On June 26, 2017 8:36:43 AM GMT+02:00, Samuel Thibault <samuel.thibault@gnu.org> wrote:

David Michael, on dim. 25 juin 2017 23:24:52 -0700, wrote:
 * config.make.in (HAVE_BLKID, HAVE_DAEMON): Drop variable.
 
 Here is a cleanup of two lines that make config.make look like it has
 configure mistakes.

Indeed.

 I was really checking around for why "make install" is now broken with
 X11 enabled.  It looks like a4f5b76390f1c7b377efbac488b57fa6756da80a is
 just incorrect.  That commit prepends $(prefix) to the target for xkb
 file names, not directories, and only one of the three files to be
 installed.
 
 Even if it added $(prefix) consistently to XKB_BASE, the value of
 XKB_BASE is either from the xkeyboard-config.pc file which is the
 system's configured directory (so it seems wrong to add another prefix
 to it), or it defaults to "$datadir/X11/xkb" where "$datadir" should
 already be configured with "$prefix" included.
 
 Should a4f5b76390f1c7b377efbac488b57fa6756da80a just be reverted?  If
 that change is correct, can someone give me an example configuration
 where it can work?

Well, see with the commit's author :)

Samuel