[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: BUG: /proc/self/exe reports relative paths, should always return abs

From: Svante Signell
Subject: Re: BUG: /proc/self/exe reports relative paths, should always return absolute paths?
Date: Fri, 15 Sep 2017 12:35:56 +0200

On Fri, 2017-09-15 at 01:49 +0200, Samuel Thibault wrote:

> Well, rather avoid having a 'filename' variable along the 'file_name'
> variable, that's confusing :)
> Better calling absolute_path for instance.

I named it abs_path.

> > ++  file_t file = __file_name_lookup (filename, O_EXEC, 0);
> Why doing this?

This is part of the original code. diff of *.diff files confused again?

> [spawni]
> > 
> Same remark, all the more so since here it's even the converse
> naming...

See above.

> While you are at it, please move the = just before the child_lookup
> call, as putting assignment within a function called would be frowned
> upon.

Done. The assignment in the function call was in the original patch: 
-    err = child_lookup (file, O_EXEC, 0, &execfile);
+    err = child_lookup (filename = file, O_EXEC, 0, &execfile);

> And there is a missing free() for spawni. The easiest is probably to
> initialize your absolute_path variable to NULL, and just always free
> it
> in out:.

OK: Done

New patch attached. Since diff -u of two *.diff files gives confusing
results, e.g. fexecve was not touched, I attach also the edited new
diff file (removed Index and replaced entries with a/ b/). Why is diff
not creating the right output?

Attachment: submitted-exec_filename.diff.diff
Description: Text Data

Attachment: submitted-exec_filename.diff.edited
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]