[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Upstreaming the glibc Hurd port

From: Florian Weimer
Subject: Re: Upstreaming the glibc Hurd port
Date: Thu, 5 Apr 2018 13:07:29 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 04/03/2018 11:58 PM, Samuel Thibault wrote:
Joseph Myers, on mar. 03 avril 2018 21:48:32 +0000, wrote:
The build for i686-gnu also fails using GCC 6 branch with

hurdsig.c: In function 'interrupted_reply_port_location.isra.1':
hurdsig.c:250:39: error: 'portloc' may be used uninitialized in this function 
    *(volatile mach_port_t *) portloc = *portloc;

I haven't investigated whether this warning is valid, or whether it's

Well, it's completely bogus: portloc is initialized just above. I don't
understand why it wouldn't see that.

You will have to look at the GIMPLE or assembler to determine if the warning is bogus after GCC has processed the setjmp call. It may very well be the case that after those transformations, there *is* an uninitialized use of portloc.

Suppressing the warning could be the wrong thing to do here. You may have to declare portloc itself volatile.

Thanks a lot for all these Hurd changes, by the way. I really appreciate your work.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]