[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [pushed][PATCH v3 1/4] Extended-remote follow exec
|
From: |
Tom Tromey |
|
Subject: |
Re: [pushed][PATCH v3 1/4] Extended-remote follow exec |
|
Date: |
Thu, 14 Feb 2019 16:11:47 -0700 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) |
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
>>>>> "Thomas" == Thomas Schwinge <thomas@codesourcery.com> writes:
Thomas> + struct cleanup *old_chain = make_cleanup (xfree,
pathname);
Tom> Please don't add new cleanups to gdb.
Tom> We're in the process of removing them all.
Tom> Instead you can use gdb::unique_xmalloc_ptr<char>, or std::string, or a
Tom> std::vector of some flavor.
I went ahead and added a patch to fix this to my series to remove
cleanups, so you don't need to do anything about this one.
Tom