[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] pci-arbiter: Fix memory bugs

From: Samuel Thibault
Subject: Re: [PATCH] pci-arbiter: Fix memory bugs
Date: Sun, 24 Nov 2019 20:54:49 +0100
User-agent: NeoMutt/20170609 (1.8.3)


Joan Lledó, le dim. 24 nov. 2019 20:47:44 +0100, a ecrit:
> Working with nested arbiters I found a heap corruption when the nested
> arbiter founds no devices b/c the master arbiter doesn't give it any
> permissions. Attached is a patch to fix it. It also removes an unneeded
> free().

Applied, thanks!

> On the other hand, I noticed that the pointer allocated at
> alloc_file_system() in pcifs.c is never freed. This pointer is needed
> during all the execution of the arbiter, so the moment to free it is
> when the arbiter is going to be stopped. Is it worth to free it just
> before the process is finished and all memory will be released anyway?

I don't think it's worth bothering.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]