bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] pci-arbiter: Rename command line options


From: Samuel Thibault
Subject: Re: [PATCH 1/2] pci-arbiter: Rename command line options
Date: Sat, 22 Feb 2020 23:19:56 +0100
User-agent: NeoMutt/20170609 (1.8.3)

Hello,

Joan Lledó via Bug reports for the GNU Hurd, le sam. 22 févr. 2020 13:59:09 
+0100, a ecrit:
> Rename some CLI options in order to add the new -D --device arg.
> 
> Replace -s by -c for subclasses.
> Replace -D by -d for domains.
>         Domains are optional from now on, default to 0.
> Replace -d by -s for devices.
>         The formerly called "devices" are now called "slots", and
>       "device" will refer to a combination of
>       Domain + Bus + Slot + Function
> Only -G and -U options create new permission scopes.

Ok, this looks good to me, thanks!

AIUI you have commit rights, so you can push it yourself?


Just one thing, which I believe shouldn't prevent from commiting what
you have already:

> +If one device is covered by more than one \
> +permission scope, only the first permission is applied.";

I'm wondering which way would be more natural to users: first rule wins
versus last rule wins.  I can't immediately think of some example of
unix command that would have the same question, to get inspiration from.
Anybody have an idea?

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]