Re: [PATCH] rumpkernel dependencies

[Damien Zammit]

On 29/3/20 4:16 pm, Damien Zammit wrote:
> Hurd TODO for Damien:
> =====================
> 
> - Fix libstore patch
Done

> - Remove useless debugging eg:

Done

> 
> - Remove most of this header:
>>> +++ b/libmachdevrump/dev_hdr.h
>> - put the files common to dde-based and rump-based libmachdev to
>>   libmachdev/.  That includes basically all your files except disk.c,
>>   machdevrump.c and Makefile. The only real discrepancy I see is in
>>   ds_routines.c' call to l4dde26_process_from_ddekit, but we can make
>>   libmachdevdde provide a function that does that call then call
>>   ds_server(). AIUI the call to is_master_device() should indeed be made
>>   like in the incubator?  I don't think we should deallocate it at the
>>   very least, was it really needed in your tests?

I compiled rumpdisk.static with the attached patches and it probed a real disk,
but I still need to test that the disk fully mounts.

I created a ds_pre_server() hook in libmachdev and implemented it for 
libmachdevdde,
and left an empty stub for libmachdevrump. 

>> - move the dde-based files (for network) to a libmachdevdde/

Done (have not tested dde with this)

>> - put your rump-based disk.c to a libmachdevrump/

Done

>> and the rumpdisk daemon will just need to link in both libmachdev and
>> libmachdevrump.

Done

0001-libstore-Add-ability-to-pass-custom-master-device-wi.patch
Description: Text Data

0002-libmachdev-Add-common-machdev.patch
Description: Text Data

0003-libmachdevrump-rumpdisk-Add-rumpdisk-support.patch
Description: Text Data

0004-libmachdevdde-Add-dde-machdev-lib-net.patch
Description: Text Data