[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCHv2 1/7] hurd: fix gnu_debug_flag type
From: |
Simon Marchi |
Subject: |
Re: [PATCHv2 1/7] hurd: fix gnu_debug_flag type |
Date: |
Sat, 30 May 2020 10:39:19 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 2020-05-29 6:00 p.m., Samuel Thibault wrote:
> Fixes
>
> ../../gdb/gnu-nat.c:96:6: error: conflicting declaration ‘bool gnu_debug_flag’
> 96 | bool gnu_debug_flag = false;
> ../../gdb/gnu-nat.c: In function ‘void _initialize_gnu_nat()’:
> ../../gdb/gnu-nat.c:3511:7: error: cannot
>
> gdb/ChangeLog:
>
> 2020-05-29 Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> * gnu-nat.h (gnu_debug_flag): Set type to bool.
>
> diff --git a/gdb/gnu-nat.h b/gdb/gnu-nat.h
> index 77c57817b2..7c36778394 100644
> --- a/gdb/gnu-nat.h
> +++ b/gdb/gnu-nat.h
> @@ -111,7 +111,7 @@ extern char *proc_string (struct proc *proc);
> __proc_pid (__proc), __proc->tid, \
> host_address_to_string (__proc) , ##args); } while (0)
>
> -extern int gnu_debug_flag;
> +extern bool gnu_debug_flag;
>
> #define debug(msg, args...) \
> do { if (gnu_debug_flag) \
>
Thanks, this is OK.
Simon
- Re: [PATCHv2 4/7] hurd: add missing include, (continued)
[PATCHv2 7/7] hurd: fix pushing target on inferior creation, Samuel Thibault, 2020/05/29
Re: [PATCHv2 1/7] hurd: fix gnu_debug_flag type,
Simon Marchi <=
Re: [PATCHv2 1/7] hurd: fix gnu_debug_flag type, Samuel Thibault, 2020/05/30