bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Help with SMP work refactor


From: Almudena Garcia
Subject: Help with SMP work refactor
Date: Thu, 18 Jun 2020 22:55:16 +0200

Hi all:

I need a bit of help in my SMP development, mainly in advice about code style and structures.

Currently, I'm rewriting the first step: cpus detection and numeration.

My work is in these files

The search of APIC table in ACPI tables is here
https://github.com/AlmuHS/GNUMach_SMP/blob/smp-new/i386/i386at/acpi_parse_apic.c
https://github.com/AlmuHS/GNUMach_SMP/blob/smp-new/i386/i386at/acpi_parse_apic.h

And this is a pseudo-class to fill and manage APIC structures
https://github.com/AlmuHS/GNUMach_SMP/blob/smp-new/i386/i386/apic.c
https://github.com/AlmuHS/GNUMach_SMP/blob/smp-new/i386/i386/apic.c

I have many doubts about functions like `acpi_apic_setup()`, which maybe is not in the appropriate file, and `pmap_aligned_table()`, which is obviously not in the correct file.

I need to know where to move `pmap_aligned_table()` and if it can be necessary to refactor `acpi_apic_setup()`.

Could you help me with these questions?
And check the entire code, if possible

Thanks

reply via email to

[Prev in Thread] Current Thread [Next in Thread]