bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] httpfs: fix HEAD request message


From: Samuel Thibault
Subject: Re: [PATCH] httpfs: fix HEAD request message
Date: Wed, 9 Sep 2020 19:16:17 +0200
User-agent: NeoMutt/20170609 (1.8.3)

Amos Jeffries, le jeu. 10 sept. 2020 04:16:54 +1200, a ecrit:
> The HEAD request used to fetch metadata about a file via HTTP
> contains a trailing 0x20 character which will cause modern HTTP/1.1
> servers to reject the request.

Commited, thanks!

I'm thinking that this should all be using \r\n instead of \n?

> ===================================================================
> RCS file: /sources/hurdextras/httpfs/http.c,v
> retrieving revision 1.3
> diff --unified -r1.3 http.c
> --- http.c    25 Jan 2013 00:50:58 -0000      1.3
> +++ http.c    9 Sep 2020 16:15:02 -0000
> @@ -110,7 +110,7 @@
>       }
> 
>       /* Send a HEAD request find header length */
> -     sprintf(buffer,"HEAD %s HTTP/1.0 \n\n",node->conn_req);
> +     sprintf(buffer,"HEAD %s HTTP/1.0\n\n",node->conn_req);
>       towrite = strlen (buffer);
>       written = TEMP_FAILURE_RETRY (write (*fd, buffer, towrite));
>       if ( written == -1 || written < towrite )
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]