Re: [PATCH] libmachdev: Install as translator when bootstrapping && fix rumpdisk injection

[Samuel Thibault]

Samuel Thibault, le sam. 14 nov. 2020 11:09:48 +0100, a ecrit:
> Damien Zammit, le sam. 14 nov. 2020 14:37:37 +1100, a ecrit:
> >  /* BSD name of whole disk device is /dev/wdXd
> > - * but we will receive /dev/wdX as the name */
> > + * but we will receive /dev/wdX as the name 
> > + * or @/dev/master:/dev/wdX */
> 
> This looks odd to me. The "@/dev/master:" part should rather be
> dropped way before, by the code that opens /dev/master to access the
> master device port before calling device_open() on it: the translators
> shouldn't have to grok which way they were accessed.

AIUI 0f77ef36b53b ("libstore: Add ability to pass custom master device
with format @master:/dev/device") should already doing it, I guess
there is another place that needs to be fixed as well, and we want to do
that instead of papering over it.

Samuel