Re: [PATCH] Hurd: Add rtld-strncpy-c.c

[Adhemerval Zanella]

On 19/01/2021 09:21, H.J. Lu via Libc-alpha wrote:
> On Tue, Jan 19, 2021 at 1:02 AM Samuel Thibault <samuel.thibault@gnu.org> 
> wrote:
>>
>> H.J. Lu via Libc-alpha, le lun. 18 janv. 2021 18:24:48 -0800, a ecrit:
>>> On Mon, Jan 18, 2021 at 4:40 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>>>>
>>>> On Mon, Jan 18, 2021 at 4:24 PM Samuel Thibault <samuel.thibault@gnu.org> 
>>>> wrote:
>>>>>
>>>>> Samuel Thibault, le mar. 19 janv. 2021 01:21:05 +0100, a ecrit:
>>>>>> H.J. Lu, le lun. 18 janv. 2021 16:17:16 -0800, a ecrit:
>>>>>>> Why doesn't hurd ld.so build script mark strncpy as needed?
>>>>>>
>>>>>> I don't even know what "hurd ld.so build script" is.
>>>>>
>>>>> More precisely, I don't see why hurd should be doing anything special
>>>>> while everything is already taken care of by elf/Makefile's librtld.map
>>>>> file scripts.
>>>>
>>>> I am taking a look.
>>>
>>> Try this.   I have no idea if it really works on hurd.
>>
>> It is working indeed.
>>
>> Samuel
> 
> Should I check it in?
> 
> 
Yes please, the loader should not use ifunc on its own string usage and
it is a build issue.