Re: PTHREAD_MUTEX_ADAPTIVE_NP undefined in Gecko

[Samuel Thibault]

Samuel Thibault, le mar. 09 févr. 2021 13:44:00 +0100, a ecrit:
> Riccardo Mottola, le mar. 09 févr. 2021 13:04:54 +0100, a ecrit:
> > Richard Braun wrote:
> > > The _NP suffix means non-posix, and is generally used for system-specific
> > > features. The use of "adaptive" mutexes is probably just an optimization,
> > > so it should be completely safe to just comment it out on systems where
> > > the macro doesn't exist (assuming it's a macro).
> > 
> > thank you, it must be optional:
> > 
> > #if (defined(LINUX) && (__GLIBC__ > 2) || (__GLIBC__ == 2 && __GLIBC_MINOR__
> > >= 2)) || \
> >     (defined(FREEBSD) && __FreeBSD_version > 700055)
> >     rv = pthread_mutexattr_settype(&_pt_mattr, PTHREAD_MUTEX_ADAPTIVE_NP);
> >     PR_ASSERT(0 == rv);
> > #endif
> > 
> > does HURD define LINUX?
> 
> No. But Linux not define LINUX either, so I rather guess that the
> application misdetected the GNU system as a GNU/Linux system and
> erroneously defined LINUX.

(Indeed the parentheses are wrong)