Re: [RFC PATCH tarfs 3/6] Implement basic read-only mmap support

[Samuel Thibault]

Sergey Bugaev, le jeu. 29 avril 2021 21:57:13 +0300, a ecrit:
> diff --git a/pager.h b/pager.h
> new file mode 100644
> index 000000000..34447c8c9
> --- /dev/null
> +++ b/pager.h
> @@ -0,0 +1,9 @@
> +#ifndef PAGER_H
> +#define PAGER_H
> +
> +struct user_pager_info;
> +extern struct port_bucket *tarfs_pager_bucket;
> +
> +error_t create_pager (struct node *node, memory_object_t *obj);
> +
> +#endif  /* PAGER_H_ */

This is missing the copyright head:ng.

> @@ -1013,8 +1015,24 @@ tarfs_mkdev_node (struct node *node, mode_t type, 
> dev_t indexes)
>  error_t
>  tarfs_io_map (struct node *node, memory_object_t *rdobj, memory_object_t 
> *wrobj)
>  {
> -  error (0, 0, "Warning: io_map () not supported");
> -  return EOPNOTSUPP;
> +  error_t err;
> +  memory_object_t obj;
> +
> +  if (!NODE_INFO(node)->pager)
> +    {
> +      err = create_pager (node, &obj);

Is the pager getting cleaned at some point?

Samuel