Re: [PATCH 1/2] startup: Mark essential tasks as our children

[Samuel Thibault]

As I already requested, please additionally try to remove

err = proc_child (procserver, fstask);
err = proc_child (procserver, authtask);

from launch_core_servers. Otherwise they will be duplicates and bring
confusion to the next reader of the code.

Samuel

Damien Zammit, le sam. 05 juin 2021 20:10:47 +1000, a ecrit:
> ---
>  startup/startup.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/startup/startup.c b/startup/startup.c
> index 9faeb462..78d69103 100644
> --- a/startup/startup.c
> +++ b/startup/startup.c
> @@ -368,6 +368,10 @@ record_essential_task (const char *name, task_t task)
>    /* Dead-name notification on the task port will tell us when it dies.  */
>    request_dead_name (task);
>  
> +  /* Make task a child of startup */
> +  if (task != mach_task_self () && task != proctask)
> +    proc_child (procserver, task);
> +
>  #if 0
>    /* Taking over the exception port will give us a better chance
>       if the task tries to get wedged on a fault.  */
> -- 
> 2.31.0
> 
>