bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH htl v3 5/5] testrun.sh: Add support for --tool=rpctrace


From: Florian Weimer
Subject: Re: [PATCH htl v3 5/5] testrun.sh: Add support for --tool=rpctrace
Date: Wed, 08 Sep 2021 08:57:43 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

* Sergey Bugaev:

> rpctrace(1) is a Hurd RPC tracer tool, which is used similar to how
> strace(1) is used on GNU/Linux.
>
> Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
> ---
>  Makefile | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index f98d5a9e67..a49870d3d1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -141,8 +141,9 @@ usage () {
>  cat << EOF
>  Usage: $$0 [OPTIONS] <program> [ARGUMENTS...]
>  
> -  --tool=TOOL  Run with the specified TOOL. It can be strace, valgrind or
> -               container. The container will run within 
> support/test-container.
> +  --tool=TOOL  Run with the specified TOOL. It can be strace, rpctrace,
> +               valgrind or container. The container will run within
> +               support/test-container.
>  EOF
>  
>    exit 1
> @@ -177,6 +178,10 @@ case "$$toolname" in
>      exec strace $(patsubst %, -E%, $(run-program-env)) \
>        $(test-via-rtld-prefix) $${1+"$$@"}
>      ;;
> +  rpctrace)
> +    exec rpctrace $(patsubst %, -E%, $(run-program-env)) \
> +      $(test-via-rtld-prefix) $${1+"$$@"}
> +    ;;
>    valgrind)
>      exec env $(run-program-env) valgrind $(test-via-rtld-prefix) $${1+"$$@"}
>      ;;

Looks okay.  This can go in separately.

Thanks,
Florian




reply via email to

[Prev in Thread] Current Thread [Next in Thread]