bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] new interface: memory_object_get_proxy


From: Samuel Thibault
Subject: Re: [PATCH] new interface: memory_object_get_proxy
Date: Mon, 1 Nov 2021 21:01:50 +0100
User-agent: NeoMutt/20170609 (1.8.3)

Sergey Bugaev, le lun. 01 nov. 2021 22:59:59 +0300, a ecrit:
> On Mon, Nov 1, 2021 at 10:36 PM Samuel Thibault <samuel.thibault@gnu.org> 
> wrote:
> > offset is inside the original object, and start is in the proxy object.
> > Think for instance of /dev/mem, within which you could want to map some
> > VGA-compatible range at 0xA0000 (that's the start), but the mapping
> > range is a subpart of the memory of some device (that's the offset).
> 
> Makes sense, thank you. But that means the code in vm_map () is wrong:
> it'd need to subtract 'start' and add 'offset' of the proxy to the
> user-specified 'offset'. Currently it adds 'start' and ignores
> 'offset'.

Ah, sorry, re-reading the comment of the RPC: it's the converse of what
I said: start is in the original memory object, and offset is in the
proxy object.

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]