Re: [hurd, commited] hurd: Make getrandom a stub inside the random translator

[Samuel Thibault]

Florian Weimer, le ven. 31 déc. 2021 21:45:18 +0100, a ecrit:
> * Samuel Thibault via Libc-alpha:
> > Joseph Myers, le ven. 31 déc. 2021 20:24:02 +0000, a ecrit:
> >> On Fri, 31 Dec 2021, Samuel Thibault wrote:
> >> 
> >> > +extern char *trivfs_server_name __attribute__((weak));
> >> 
> >> This looks like it has caused many linknamespace test failures, of the 
> >> form:
> >> 
> >> [initial] __assert_fail -> [libc.a(assert.o)] free -> [libc.a(malloc.o)] 
> >> __getrandom -> [libc.a(getrandom.o)] trivfs_server_name
> >
> > Uh, weak references are red-flagged?
> 
> They are.  A symbol collision will break glibc functionality because
> the application scribbles over the internal variable.
> 
> > Where should I white-flag these?
> 
> You need to rename the symbol to __trivfs_server_name.

Ok, done so!

Samuel