[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] pci-arbiter: Stop using deprecated region memory pointer
From: |
Samuel Thibault |
Subject: |
Re: [PATCH] pci-arbiter: Stop using deprecated region memory pointer |
Date: |
Wed, 5 Jan 2022 13:45:46 +0100 |
User-agent: |
NeoMutt/20170609 (1.8.3) |
Joan Lledó, le mer. 05 janv. 2022 13:08:02 +0100, a ecrit:
> - if (region->memory == 0)
> + if (*addr == 0)
> {
> - err = pci_device_map_range (device, region->base_addr, region->size,
> - PCI_DEV_MAP_FLAG_WRITABLE, ®ion->memory);
> + if (region->base_addr > 0x100000)
Rather >= ?
Also, why this address? Putting a comment there would be welcome to
explain the magic number.
> + err = pci_device_map_range (device, region->base_addr, region->size,
> + PCI_DEV_MAP_FLAG_WRITABLE, addr);
> + else
> + err = pci_device_map_legacy (device, region->base_addr, region->size,
> + PCI_DEV_MAP_FLAG_WRITABLE, addr);
> }
>
> return err;
Samuel
- [PATCH] hurd: Implement device memory mapping, (continued)
- [PATCH] hurd: Implement device memory mapping, Joan Lledó, 2022/01/05
- Re: [PATCH] hurd: Implement device memory mapping, Samuel Thibault, 2022/01/08
- Re: [PATCH] hurd: Implement device memory mapping, Samuel Thibault, 2022/01/08
- Re: [PATCH] hurd: Implement device memory mapping, Samuel Thibault, 2022/01/08
- Re: [PATCH] hurd: Implement device memory mapping, Joan Lledó, 2022/01/09
- Re: [PATCH] hurd: Implement device memory mapping, Samuel Thibault, 2022/01/09
- Re: [PATCH] hurd: Implement device memory mapping, Samuel Thibault, 2022/01/09
- Re: [PATCH] hurd: Implement device memory mapping, Joan Lledó, 2022/01/23
- Re: [PATCH] hurd: Implement device memory mapping, Samuel Thibault, 2022/01/23
[PATCH] pci-arbiter: Stop using deprecated region memory pointer, Joan Lledó, 2022/01/05
Re: [PATCH] pci-arbiter: Stop using deprecated region memory pointer, Samuel Thibault, 2022/01/07