[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/7] libpager: fix assertion unsigned against 0
From: |
Etienne Brateau |
Subject: |
[PATCH 2/7] libpager: fix assertion unsigned against 0 |
Date: |
Wed, 19 Jan 2022 20:29:40 +0100 |
Comparing an unsigned to be superior or equals to 0 is always true,
instead move the assert before the substraction and compare it to the
value to substract.
---
libpager/pager-memcpy.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libpager/pager-memcpy.c b/libpager/pager-memcpy.c
index 12515933..5a5aac2a 100644
--- a/libpager/pager-memcpy.c
+++ b/libpager/pager-memcpy.c
@@ -130,13 +130,13 @@ pager_memcpy (struct pager *pager, memory_object_t memobj,
vm_deallocate (mach_task_self (), window, window_size);
+ assert_backtrace (n >= copy_count);
+ assert_backtrace (to_copy >= copy_count);
+
offset += copy_count;
other += copy_count;
to_copy -= copy_count;
n -= copy_count;
-
- assert_backtrace (n >= 0);
- assert_backtrace (to_copy >= 0);
}
while (to_copy > 0);
--
2.34.1
- [PATCH 1/7] libpager: fix a comparision between signed and unsigned, Etienne Brateau, 2022/01/19
- [PATCH 2/7] libpager: fix assertion unsigned against 0,
Etienne Brateau <=
- [PATCH 3/7] libstore: fix type of a counter, Etienne Brateau, 2022/01/19
- [PATCH 4/7] libdiskfs: improve asserts and remove a sign compare warning, Etienne Brateau, 2022/01/19
- [PATCH 7/7] proc: Fix variable type, Etienne Brateau, 2022/01/19
- [PATCH 6/7] libnetfs: fix type of variable, Etienne Brateau, 2022/01/19
- [PATCH 5/7] libps: fix some signed vs unsigned comparision, Etienne Brateau, 2022/01/19