bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 11/17] ext2fs: resolve a todo, check writability before writi


From: Samuel Thibault
Subject: Re: [PATCH 11/17] ext2fs: resolve a todo, check writability before writing
Date: Sun, 23 Jan 2022 12:06:58 +0100
User-agent: NeoMutt/20170609 (1.8.3)

Applied, thanks!

Etienne Brateau, le dim. 23 janv. 2022 05:17:09 +0100, a ecrit:
> ---
>  ext2fs/hyper.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/ext2fs/hyper.c b/ext2fs/hyper.c
> index 65a2937e..9bff609f 100644
> --- a/ext2fs/hyper.c
> +++ b/ext2fs/hyper.c
> @@ -199,6 +199,9 @@ diskfs_set_hypermetadata (int wait, int clean)
>  
>    if (sblock_dirty)
>     {
> +     if (diskfs_readonly)
> +       return EROFS; /* impossible to write */
> +
>       /* Before writing, set the time of write */
>       sblock->s_wtime = htole32(diskfs_mtime->seconds);
>       sblock_dirty = 0;
> @@ -209,7 +212,6 @@ diskfs_set_hypermetadata (int wait, int clean)
>  
>    sync_global (wait);
>  
> -  /* Should check writability here and return EROFS if necessary. XXX */
>    return 0;
>  }
>  
> -- 
> 2.34.1
> 
> 

-- 
Samuel
c> ah (on trouve fluide glacial sur le net, ou il faut aller dans le monde reel 
?)
s> dans le monde reel
c> zut



reply via email to

[Prev in Thread] Current Thread [Next in Thread]