Re: [PATCH 13/17] ext2fs: remove a #define not_yet

[Etienne Brateau]

Not in ext2. It was added in ext4.

Le dim. 23 janv. 2022 à 10:40, Samuel Thibault <samuel.thibault@gnu.org> a écrit :

Etienne Brateau, le dim. 23 janv. 2022 05:17:11 +0100, a ecrit:
> ext2fs will never support time precision better than second

? There is *_ctime_extra in newer definitions of the filesystem.

> ---
>  ext2fs/inode.c | 25 +++----------------------
>  1 file changed, 3 insertions(+), 22 deletions(-)
>
> diff --git a/ext2fs/inode.c b/ext2fs/inode.c
> index 511faf6e..830b17a2 100644
> --- a/ext2fs/inode.c
> +++ b/ext2fs/inode.c
> @@ -135,23 +135,14 @@ diskfs_user_read_node (struct node *np, struct lookup_context *ctx)
>    st->st_gen = le32toh (di->i_generation);
> 
>    st->st_atim.tv_sec = le32toh (di->i_atime);
> -#ifdef not_yet
> -  /* ``struct ext2_inode'' doesn't do better than sec. precision yet.  */
> -#else
> +  /* ``struct ext2_inode'' doesn't do better than sec. precision.  */
>    st->st_atim.tv_nsec = 0;
> -#endif
>    st->st_mtim.tv_sec = le32toh (di->i_mtime);
> -#ifdef not_yet
> -  /* ``struct ext2_inode'' doesn't do better than sec. precision yet.  */
> -#else
> +  /* ``struct ext2_inode'' doesn't do better than sec. precision.  */
>    st->st_mtim.tv_nsec = 0;
> -#endif
>    st->st_ctim.tv_sec = le32toh (di->i_ctime);
> -#ifdef not_yet
> -  /* ``struct ext2_inode'' doesn't do better than sec. precision yet.  */
> -#else
> +  /* ``struct ext2_inode'' doesn't do better than sec. precision.  */
>    st->st_ctim.tv_nsec = 0;
> -#endif
> 
>    st->st_blocks = le32toh (di->i_blocks);
> 
> @@ -408,18 +399,8 @@ write_node (struct node *np)
>        di->i_links_count = htole16 (st->st_nlink);
> 
>        di->i_atime = htole32(st->st_atim.tv_sec);
> -#ifdef not_yet
> -      /* ``struct ext2_inode'' doesn't do better than sec. precision yet.  */
> -      di->i_atime.tv_nsec = htole32 (st->st_atim.tv_nsec);
> -#endif
>        di->i_mtime = htole32 (st->st_mtim.tv_sec);
> -#ifdef not_yet
> -      di->i_mtime.tv_nsec = htole32 (st->st_mtim.tv_nsec);
> -#endif
>        di->i_ctime = htole32 (st->st_ctim.tv_sec);
> -#ifdef not_yet
> -      di->i_ctime.tv_nsec = htole32 (st->st_ctim.tv_nsec);
> -#endif
> 
>        /* Convert generic flags in ST->st_flags to ext2-specific flags in DI
>           (but don't mess with ext2 flags we don't know about).  The original
> --
> 2.34.1