Re: [PATCH 4/6] fix console setting from cmdline

[Samuel Thibault]

Luca Dariz, le ven. 28 janv. 2022 19:24:07 +0100, a ecrit:
> The leading space prevents it working if console=comX is the only
> argument.

But it would be confused with another parameter which would be
foobarconsole=bla

You'd probably want to make the code also try strncmp(kernel_cmdline,
CONSOLE_PARAMETER+1)

Samuel

> Signed-off-by: Luca Dariz <luca@orpolo.org>
> ---
>  i386/i386at/com.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/i386/i386at/com.c b/i386/i386at/com.c
> index 3402a025..d1de51c0 100644
> --- a/i386/i386at/com.c
> +++ b/i386/i386at/com.c
> @@ -183,7 +183,7 @@ comcnprobe(struct consdev *cp)
>       struct  bus_device *b;
>       int     maj, unit, pri;
>  
> -#define CONSOLE_PARAMETER " console=com"
> +#define CONSOLE_PARAMETER "console=com"
>       u_char *console = (u_char *) strstr(kernel_cmdline, CONSOLE_PARAMETER);
>  
>       if (console)
> -- 
> 2.30.2
> 
>