[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/6] fix register corruption in irq on qemu
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 3/6] fix register corruption in irq on qemu |
Date: |
Wed, 2 Feb 2022 08:46:11 +0100 |
User-agent: |
NeoMutt/20170609 (1.8.3) |
Luca, le mer. 02 févr. 2022 08:15:05 +0100, a ecrit:
> Il 28/01/22 20:57, Samuel Thibault ha scritto:
> > Luca Dariz, le ven. 28 janv. 2022 19:24:06 +0100, a ecrit:
> > > it seems rbx is corrupted during interrupt handlers.
> >
> > Perhaps just use rcx instead?
>
> I'm not sure what causes this corruption, according do x86_64 calling
> conventions rbx should be preserved across function calls, so maybe the
> problem lies elsewhere.
>
> Anyway, rcx is not preserved, so it should be pushed here indeed, I'll add
> it.
That's not what I meant :) I meant to *use* ecx instead of ebx, in the
computation. Since ecx is already clobbered below, after the call.
Registers are already saved by all_intrs etc. before calling the
interrupt asm function.
Samuel