bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnumach: Remove PCI_CFG2_* as a reserved ioport range


From: Samuel Thibault
Subject: Re: [PATCH] gnumach: Remove PCI_CFG2_* as a reserved ioport range
Date: Tue, 23 Aug 2022 12:40:53 +0200
User-agent: NeoMutt/20170609 (1.8.3)

Damien Zammit, le mar. 23 août 2022 03:26:49 +0000, a ecrit:
> PCI CONF2 access method was deprecated in PCI v2.0
> 
> Also, the conf2 ioport range is only activated for use
> as pci configuration space when conf1 registers are accessed
> in a particular sequence.
> 
> Since the pci-arbiter does not access the conf1 forwarding register,
> we are safe to remove this completely from gnumach to allow
> normal I/O use of the conf2 range as modern hardware expects.

Applied, thanks!

> ---
>  i386/i386/io_perm.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/i386/i386/io_perm.c b/i386/i386/io_perm.c
> index c966102c..6db60f73 100644
> --- a/i386/i386/io_perm.c
> +++ b/i386/i386/io_perm.c
> @@ -70,12 +70,9 @@
> 
>  #define PCI_CFG1_START       0xcf8
>  #define PCI_CFG1_END 0xcff
> -#define PCI_CFG2_START       0xc000
> -#define PCI_CFG2_END 0xcfff
> 
>  #define CONTAINS_PCI_CFG(from, to) \
> -  ( ( ( from <= PCI_CFG1_END ) && ( to >= PCI_CFG1_START ) ) || \
> -    ( ( from <= PCI_CFG2_END ) && ( to >= PCI_CFG2_START ) ) )
> +  ( ( from <= PCI_CFG1_END ) && ( to >= PCI_CFG1_START ) )
> 
>  
>  /* Our device emulation ops.  See below, at the bottom of this file.  */
> --
> 2.34.1
> 
> 
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]