[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/15] x86_64: expand and shrink messages in copy{in, out}msg
|
From: |
Samuel Thibault |
|
Subject: |
Re: [PATCH 10/15] x86_64: expand and shrink messages in copy{in, out}msg routines |
|
Date: |
Tue, 30 Aug 2022 08:17:39 +0200 |
|
User-agent: |
NeoMutt/20170609 (1.8.3) |
Luca, le mar. 30 août 2022 07:57:23 +0200, a ecrit:
> Il 28/08/22 15:13, Samuel Thibault ha scritto:
> > This was breaking the 32bit kernel case. I have pushed a fix for that,
> > that does this move of setting msgh_size to copyinmsg itself.
>
> The 32-bit case was breaking because it needed an updated MIG,
? You mean that the kernel would have to trust userland to set msgh_size
properly? We cannot do that :)
> As far as I understand, these routines should use stac/clac if the SMAP cpu
> feature is supported on x86 as the Linux counterparts, so we would catch
> these cases earlier.
Yes.
> I didn't find anything related to cpu features yet,
git grep -i feature i386/
> Is there a minimum that we can assume to have?
I'd rather not. And particularly not SMAP which is very recent :)
Samuel