Re: [PATCH 02/12] kern/startup: Disable interrupts before starting APs

[Samuel Thibault]

Hello,

Damien Zammit, le mar. 25 oct. 2022 10:55:36 +0000, a ecrit:
> ---
>  kern/startup.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kern/startup.c b/kern/startup.c
> index 1f873192..499ef0f1 100644
> --- a/kern/startup.c
> +++ b/kern/startup.c
> @@ -242,6 +242,7 @@ void start_kernel_threads(void)
>       /*
>        *      Allow other CPUs to run.
>        */
> +     splhigh();

I'd say we'd rather do it also when NCPUS==1? Otherwise we'll have
different behavior in smp and non-smp, which is prone to bring headaches
later.

>       start_other_cpus();
>  #endif       /* NCPUS > 1 */
> 
> --
> 2.34.1
> 
> 
> 

-- 
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.