[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH rumpkernel] pci-userspace: Add acpi lookup of irqs with fallb
|
From: |
Samuel Thibault |
|
Subject: |
Re: [PATCH rumpkernel] pci-userspace: Add acpi lookup of irqs with fallback |
|
Date: |
Sun, 15 Jan 2023 14:41:24 +0100 |
|
User-agent: |
NeoMutt/20170609 (1.8.3) |
Hello,
Damien Zammit, le dim. 15 janv. 2023 07:53:53 +0000, a ecrit:
> +@@ -363,6 +370,7 @@
> + rumpcomp_pci_irq_map(unsigned bus, unsigned dev, unsigned fun,
> + int intrline, unsigned cookie)
> + {
> ++ int ret;
> + struct irq *irq;
> + irq = malloc(sizeof(*irq));
> + if (irq == NULL)
> +@@ -372,7 +380,13 @@
> + irq->bus = bus;
> + irq->dev = dev;
> + irq->fun = fun;
> +- irq->intrline = intrline;
> ++
> ++ /* We can do better by reading irq from acpi device, but with fallback
> */
> ++ ret = acpi_get_pci_irq (acpi_dev, bus, dev, fun, &irq->intrline);
Better not call at all if acpi_dev == MACH_PORT_NULL.
Samuel