bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix some compiler warnings


From: Samuel Thibault
Subject: Re: [PATCH] Fix some compiler warnings
Date: Wed, 18 Jan 2023 02:02:09 +0100
User-agent: NeoMutt/20170609 (1.8.3)

Hello,

Svante Signell, le mar. 17 janv. 2023 13:15:27 +0100, a ecrit:
> --- hurd-git/ext2fs/ext2fs.c  2022-12-08 15:05:29.808000000 +0100
> +++ hurd-git/ext2fs/ext2fs.c  2022-12-08 19:11:12.604000000 +0100
> @@ -232,7 +232,7 @@
>    if (store->size < SBLOCK_OFFS + SBLOCK_SIZE)
>      ext2_panic ("device too small for superblock (%Ld bytes)", store->size);
>    if (store->log2_blocks_per_page < 0)
> -    ext2_panic ("device block size (%zu) greater than page size (%lu)",
> +    ext2_panic ("device block size (%zu) greater than page size (%u)",
>               store->block_size, vm_page_size);

But conversely when we'll build it in 64bit, vm_page_size (actually
uintptr_t) will be an unsigned long.

This needs to be fixed the *proper* way: either use the PRIuPTR macro,
or cast the value into unsigned long.

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]