Re: [PATCH] Add libraries to Makefiles.

[Samuel Thibault]

Svante Signell, le mer. 18 janv. 2023 12:36:55 +0100, a ecrit:
> On Wed, 2023-01-18 at 11:54 +0100, Samuel Thibault wrote:
> > 
> > Then you need to check that the linking of e.g. storeio does use the
> > shared library and not the static library. For instance you can re-run
> > the corresponding linking command and add -Wl,-verbose to check in the
> > verbose output which precise libstore file it takes.
> 
> 
> /cross-tools/bin/i686-pc-gnu-gcc -L. -L../libbpf/ -L../libcons/ -
> L../libdiskfs/ -L../libfshelp/ -L../libftpconn/ -L../libhurdbugaddr/ -
> L../libhurd-slab/ -L../libihash/ -L../libiohelp/ -L../libmachdev/ -
> L../libnetfs/ -L../libpager/ -L../libpipe/ -L../libports/ -L../libps/ -
> L../libshouldbeinlibc/ -L../libstore/ -L../libtrivfs/ -Wl,-rpath-
> link=../libbpf/ -Wl,-rpath-link=../libcons/ -Wl,-rpath-
> link=../libdiskfs/ -Wl,-rpath-link=../libfshelp/ -Wl,-rpath-
> link=../libftpconn/ -Wl,-rpath-link=../libhurdbugaddr/ -Wl,-rpath-
> link=../libhurd-slab/ -Wl,-rpath-link=../libihash/ -Wl,-rpath-
> link=../libiohelp/ -Wl,-rpath-link=../libmachdev/ -Wl,-rpath-
> link=../libnetfs/ -Wl,-rpath-link=../libpager/ -Wl,-rpath-
> link=../libpipe/ -Wl,-rpath-link=../libports/ -Wl,-rpath-link=../libps/
> -Wl,-rpath-link=../libshouldbeinlibc/ -Wl,-rpath-link=../libstore/ -
> Wl,-rpath-link=../libtrivfs/ -std=gnu99 -fgnu89-inline -Wall -g -O3 -
> fno-strict-aliasing  -g -O2  -Wl,-verbose,-L/tools/lib -lblkid -luuid -
> lz -lncursesw -ltinfow -ldl  -uargp_program_bug_address -o storeio \
>               dev.o storeio.o open.o pager.o io.o \
>       '-Wl,-(' ../libhurdbugaddr/libhurdbugaddr.so
> ../libtrivfs/libtrivfs.so ../libpager/libpager.so
> ../libfshelp/libfshelp.so ../libiohelp/libiohelp.so
> ../libstore/libstore.so ../libports/libports.so ../libihash/libihash.so
> ../libshouldbeinlibc/libshouldbeinlibc.so \
>                 -lpthread -lz \
>       '-Wl,-)'
> ...
> <a lot of searches for libbz fails>
> attempt to open /tools/lib/libz.so succeeded
> /tools/lib/libz.so

I'm not talking about libz.so, but about libstore.so. Is that
libstore.so really a shared library that has libz in NEEDED? If so there
is really no need to add -lz to linking storeio. Unless you actually
send us the actual error message you get without an explicit -lz, we
can't know why you'd have to add -lz.

Samuel