[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] Add cpu_number and cpuboot
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 4/4] Add cpu_number and cpuboot |
Date: |
Tue, 24 Jan 2023 08:54:04 +0100 |
User-agent: |
NeoMutt/20170609 (1.8.3) |
Flávio Cruz, le mar. 24 janv. 2023 01:15:15 -0500, a ecrit:
> + int kernel_id;
> + unsigned long flags;
> +
> + cpu_intr_save(&flags);
> +
> + kernel_id = apic_get_cpu_kernel_id(apic_get_current_cpu());
> +
> + cpu_intr_restore(flags);
> +
> + return kernel_id;
>
>
> Might be unrelated to this change, but will this be portable for x86_64? It
> seems we either should use uint32_t to store EFLAGS or use pushfq/popfq to get
> RFLAGS instead.
cpu_get_eflags will already use pushfq/popfq, won't it? (since it takes
the unsigned long output parameter.
Samuel
Re: [PATCH 4/4] Add cpu_number and cpuboot, Samuel Thibault, 2023/01/29
[PATCH 3/4] i386: Fix lapic and ioapic for smp, Damien Zammit, 2023/01/21