bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH gnumach] Track task and thread time using time_value64_t.


From: Flávio Cruz
Subject: Re: [PATCH gnumach] Track task and thread time using time_value64_t.
Date: Wed, 15 Mar 2023 01:54:56 -0400


On Mon, Mar 13, 2023 at 3:41 PM Samuel Thibault <samuel.thibault@gnu.org> wrote:
Hello,

Flavio Cruz, le lun. 13 mars 2023 01:42:12 -0400, a ecrit:
> @@ -854,21 +849,22 @@ kern_return_t task_info(
>               task_thread_times_info_t times_info;
>               thread_t        thread;

> -             if (*task_info_count < TASK_THREAD_TIMES_INFO_COUNT) {
> +             /* Callers might not known about time_value64_t fields yet. */
> +             if (*task_info_count < TASK_THREAD_TIMES_INFO_COUNT - (2 * sizeof(time_value64_t)) / sizeof(integer_t)) {
>                   return KERN_INVALID_ARGUMENT;
>               }

I don't understand this: are we changing task_thread_times_info_t?
task_thread_times_info is already containing exactly two
rpc_time_value_t, this patch doesn't seem to be changing it?

Correct, I accidentally included a change that will be included in the next patch.


Samuel

reply via email to

[Prev in Thread] Current Thread [Next in Thread]