Re: [PATCH hurd] Use long_integer_t for exception_raise RPCs

[Samuel Thibault]

Applied, thanks!

Flavio Cruz, le sam. 08 avril 2023 00:20:44 -0400, a ecrit:
> Also update the crash_dump_task RPC since it gets the subcode from the
> signal details in Glibc.
> 
> This should fix the existing build error.
> ---
>  hurd/crash.defs               | 2 +-
>  mach-defpager/default_pager.c | 2 +-
>  proc/mgt.c                    | 2 +-
>  proc/proc_exc.defs            | 2 +-
>  trans/crash.c                 | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/hurd/crash.defs b/hurd/crash.defs
> index 42958617..d9a9612f 100644
> --- a/hurd/crash.defs
> +++ b/hurd/crash.defs
> @@ -43,5 +43,5 @@ routine crash_dump_task (
>       task: task_t;
>       file: file_t;
>       signo: int; sigcode: integer_t; sigerror: int;
> -     exc: natural_t; code: natural_t; subcode: natural_t;
> +     exc: natural_t; code: natural_t; subcode: long_natural_t;
>       cttyid_port: mach_port_send_t);
> diff --git a/mach-defpager/default_pager.c b/mach-defpager/default_pager.c
> index b8158b35..a0547008 100644
> --- a/mach-defpager/default_pager.c
> +++ b/mach-defpager/default_pager.c
> @@ -3788,7 +3788,7 @@ void paging_space_info(vm_size_t *totp, vm_size_t 
> *freep)
>  kern_return_t
>  catch_exception_raise(mach_port_t exception_port,
>               mach_port_t thread, mach_port_t task,
> -             int exception, int code, int subcode)
> +             int exception, int code, long_integer_t subcode)
>  {
>       ddprintf ("(default_pager)catch_exception_raise(%d,%d,%d)\n",
>              exception, code, subcode);
> diff --git a/proc/mgt.c b/proc/mgt.c
> index 25844dbf..f4bd6225 100644
> --- a/proc/mgt.c
> +++ b/proc/mgt.c
> @@ -661,7 +661,7 @@ S_proc_exception_raise (struct exc *e,
>                       mach_port_t task,
>                       integer_t exception,
>                       integer_t code,
> -                     integer_t subcode)
> +                     long_integer_t subcode)
>  {
>    error_t err;
>    struct proc *p;
> diff --git a/proc/proc_exc.defs b/proc/proc_exc.defs
> index 9dc3626e..bb4563a4 100644
> --- a/proc/proc_exc.defs
> +++ b/proc/proc_exc.defs
> @@ -49,4 +49,4 @@ routine proc_exception_raise (
>       task: mach_port_t;
>       exception: integer_t;
>       code: integer_t;
> -     subcode: integer_t);
> +     subcode: long_integer_t);
> diff --git a/trans/crash.c b/trans/crash.c
> index 6d494ce0..f4a21176 100644
> --- a/trans/crash.c
> +++ b/trans/crash.c
> @@ -249,7 +249,7 @@ S_crash_dump_task (mach_port_t port,
>                  mach_port_t reply_port, mach_msg_type_name_t reply_type,
>                  task_t task, file_t core_file,
>                  int signo, integer_t sigcode, int sigerror,
> -                natural_t exc, natural_t code, natural_t subcode,
> +                natural_t exc, natural_t code, long_natural_t subcode,
>                  mach_port_t ctty_id)
>  {
>    error_t err;
> -- 
> 2.39.2
> 
> 

-- 
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.