[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH glibc 24/34] hurd: Only check for TLS initialization insi

From: Samuel Thibault
Subject: Re: [RFC PATCH glibc 24/34] hurd: Only check for TLS initialization inside rtld or in static builds
Date: Wed, 12 Apr 2023 11:00:25 +0200
User-agent: NeoMutt/20170609 (1.8.3)

Sergey Bugaev, le mer. 12 avril 2023 11:36:58 +0300, a ecrit:
> Alright, this went much as expected. First it took an eternity to
> compile (SMP support can't come soon enough), and second, the testuite
> has brought the system into a bad state and didn't complete. In
> particular: it managed to terminate my SSH session several times (I
> don't know how), and eventually it ran into that networking stack
> deadlock (the only way out of which seems to be reboot-hurd on the
> console). So I still can not run the testsuite on my end.

Was that tst-spawn6? We'd probably have to disable that as well, you can
just add 

tests-unsupported += tst-spawn6

to sysdeps/mach/hurd/Makefile

Possibly also test-lfs:

tests-unsupported += test-lfs

> But the tests that did run seem to mostly have worked. There were some
> failures here and there (I don't know which ones are expected)

You can run on master to get the list of current expected failures.

> Could you please point me to a specific test case

Actually all cases that actually execute something, fail. So for
instance the very first, csu/test-as-const-rtld-sizes

> (and not just "run the whole thing") that started failing because of
> this change, and teach me how to run just that one? I have read [0],
> but that says, "To test just one test you have to have already run the
> entire testsuite", which is a non-starter.

You can use

./testrun.sh csu/test-as-const-rtld-sizes

> Would it have been easy for me to run the full test suite, I would
> surely do that before submitting any patches. But it's not.

Then it's simple: we have to fix that first.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]