[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v8 0/2 hurd] Add irqhelp and clean up ddekit

From: Samuel Thibault
Subject: Re: [PATCH v8 0/2 hurd] Add irqhelp and clean up ddekit
Date: Fri, 8 Mar 2024 17:16:28 +0100
User-agent: NeoMutt/20170609 (1.8.3)

Damien Zammit, le ven. 08 mars 2024 06:57:47 +0000, a ecrit:
> I think we need to allow the irq handler to be called one more time,
> because we don't know if there is a pending interrupt until we need
> to handle one.
> Once we enable the irq one more time, it is necessary
> to handle the last interrupt before quitting the handler.

I believe we still don't need to call the application handler. The fact
that the application calls irqhelp_remove_interrupt_handler means that
it's done with the hardware, and doesn't care about getting notified
of more interrupts. Worse, we should really *not* call the handler one
more time after irqhelp_remove_interrupt_handler returns, since the
application could very well want to deinitialize some data and whatnot
that the handler could try to access.

Leaving the application handler pointer recorded somewhere without
actually letting the application control when it's actually finished
being used is asking for trouble :) And I really think the application
doesn't need any more notification after calling
irqhelp_remove_interrupt_handler anyway.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]