[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-inetutils] Anomalies in the code
From: |
Debarshi Ray |
Subject: |
Re: [bug-inetutils] Anomalies in the code |
Date: |
Thu, 8 May 2008 14:28:38 +0530 |
> It is safe to return NULL here. When env_default is called
> with init=1, its return value is ignored anyway.
Ok. Thank you.
> As a side note, there is a more serious bug in env_define,
> command.c:1918. The return value from malloc is not tested,
> which can lead to a coredump. I'd propose to change it to
> xmalloc to be on a safe side.
Ok. I shall do it in a later changeset. For the moment I am only
concentrating on the warnings.
Happy hacking,
Debarshi
--
"From what we get, we can make a living; what we give, however, makes a life."
-- Arthur Ashe