[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-inetutils] [PATCH] Removing ORIGINAL_SOURCE
From: |
Jeff Bailey |
Subject: |
Re: [bug-inetutils] [PATCH] Removing ORIGINAL_SOURCE |
Date: |
Tue, 13 May 2008 14:46:45 -0700 |
On Tue, May 13, 2008 at 10:40 AM, Alfred M. Szmidt <address@hidden> wrote:
> > After doing this, is the function string_to_flags from
> > libls/stat_flags.c still necessary? It is also not being called
> > from anywhere.
> >
> > Please don't remove it, it can be useful in the future.
>
> Blech, that's an awful reason to keep something around. If it were
> universally useful, it would be in some major library.
>
> I'd simply say YAGNI, and get rid of any code that's not being used.
> If we turn out to be wrong, that's what revision control is for.
>
> I would agree with you _IFF_ the code was in a utility, the code is in
> a library.
The library has no external consumers, and has no promised stable
API/ABI. The library argument doesn't fly.
--
Jeff Bailey - http://www.raspberryginger.com/jbailey/
"Gay marriage will encourage people to be gay, in the same way that
hanging around tall people will make you tall."
- Peter Gallagher