[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug-inetutils] Re: Trivial in-code comments for src/inetd.c.
From: |
Simon Josefsson |
Subject: |
[bug-inetutils] Re: Trivial in-code comments for src/inetd.c. |
Date: |
Sat, 04 Sep 2010 22:40:22 +0200 |
User-agent: |
Gnus/5.110011 (No Gnus v0.11) Emacs/23.2 (gnu/linux) |
Mats Erik Andersson <address@hidden> writes:
> fredag den 3 september 2010 klockan 22:51 skrev Simon Josefsson detta:
>> Mats Erik Andersson <address@hidden> writes:
>>
>> > Hello all,
>> >
>> > when working in a Debian package bug for "inetutils-inetd" a few
>> > days ago, I came across some plain inaccuracies in the comments
>> > regarding code behaviour for IPv6 versus IPv4. My suggestions
>> > are collected in a straightforward difference text.
>>
>> It looks good, but could you send it using git-format-patch instead?
>
> Is "git diff" not the correct manner? I am not proficient enough
> with Git to know my way around there. Only slowly picking things
> up as I go along. Regrettably!
It is better (i.e., easier for us) if you commit your work locally
(possibly on a branch), with a suitable commit comment, and then prepare
that commit using git-format-patch and mail it to us. The recipe for
doing this is on the front page of http://git-scm.com/ and explained in
git howtos.
I can commit from git-diff output too, but if you are going to send more
patches, it might be a good opportunity to learn the "preferred" way.
This will also prepare you for real write access to the git
repository...
/Simon