[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-inetutils] Re: [PATCH] Inetd and test scripts
From: |
Alfred M. Szmidt |
Subject: |
Re: [bug-inetutils] Re: [PATCH] Inetd and test scripts |
Date: |
Tue, 02 Nov 2010 18:30:41 -0400 |
> --- a/tests/tftp.sh
> +++ b/tests/tftp.sh
> @@ -22,13 +22,15 @@
> TFTP="${TFTP:-../src/tftp$EXEEXT}"
> TFTPD="${TFTPD:-$PWD/../src/tftpd$EXEEXT}"
> INETD="${INETD:-../src/inetd$EXEEXT}"
> -IFCONFIG="${IFCONFIG:-../ifconfig/ifconfig$EXEEXT}"
> +IFCONFIG="${IFCONFIG:-../ifconfig/ifconfig$EXEEXT --format=unix}"
>
> -PORT=7777
> +AF=${AF:-inet}
> +PROTO=${PROTO:-udp}
> +PORT=${PORT:-7777}
Not sure these were absolutely necessary...
I see no reason why they are unnecessary, can you explain why you
think otherwise?
> +# Check that the port is still available
> +netstat -na | grep -q "^$PROTO .*$PORT "
> +if test $? -eq 0; then
> + echo "Desired port $PORT/$PROTO is already in use."
> + exit 1
> +fi
This breaks because ‘netstat’ may not be in $PATH; in particular, it
breaks the Hydra builder: <http://hydra.nixos.org/build/727555>.
Why is netstat not in PATH?
Furthermore, I think it’s useless: if ‘inetd’ fails to listen on $PORT,
the remainder of the script will notice it anyway.
Can you please fix it?
[...]
> +# Wait somewhat for the service to settle
> +sleep 1
Pointless.
inetd is spawned into the background, and you can get a small race
condition so the sleep does no harm. It would be a good idea why you
think something is pointless, since it might not be evident otherwise.
Cheers!
Re: [bug-inetutils] Re: [PATCH] Inetd and test scripts,
Alfred M. Szmidt <=
Re: [bug-inetutils] Re: [PATCH] Inetd and test scripts, Alfred M. Szmidt, 2010/11/05