[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-inetutils] [PATCH] inetd: Listen on connections for tcpmux serv
From: |
Guillem Jover |
Subject: |
Re: [bug-inetutils] [PATCH] inetd: Listen on connections for tcpmux services |
Date: |
Thu, 18 Nov 2010 04:00:15 +0100 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
Hi!
On Sat, 2010-11-13 at 11:30:26 +0100, Mats Erik Andersson wrote:
> måndag den 6 september 2010 klockan 11:20 skrev Guillem Jover detta:
> > diff --git a/src/inetd.c b/src/inetd.c
> > index 354ae1d..1c51a51 100644
> > --- a/src/inetd.c
> > +++ b/src/inetd.c
> > @@ -1161,10 +1161,8 @@ nextconfig (const char *file)
> > {
> > sep->se_fd = -1;
> > sep->se_checked = 1;
> > - enter (sep);
> > }
> > - else
> > - expand_enter (sep);
> > + expand_enter (sep);
> > freeconfig (sep);
> > }
> > endconfig (fconfig);
>
> Since expand_enter() uses getaddrinfo(3) in resolving the service
> name, every effort to start any TCPMUX service will fail immediately.
> The original coding is correct. Sorry to say, but no testing to actually
> start a custom TCPMUX service, using this alteration, could ever have
> been performed. It would have been sufficent to try
>
> tcpmux stream tcp nowait root internal
> tcpmux/honeybee stream tcp nowait nobody /bin/date date
>
> and
>
> $ echo "honeybee" | nc localhost 1
Hmm, you are right, although I actually tested with similar entries,
my only guess now is that I screwed on the testing, probably with
mismatching code and binaries. Sorry about that.
thanks,
guillem