Re: [bug-inetutils] Two errors in FreeBSD and GNU/kFreeBSD.

[Mats Erik Andersson]

torsdag den 18 november 2010 klockan 05:12 skrev Guillem Jover detta:
> Hi!
> 
> On Wed, 2010-11-03 at 09:42:43 +0100, Mats Erik Andersson wrote:
> > Two minor errors: one at compile time and one
> > at execution time. The latter affects only
> > FreeBSD to my knowledge.
> 
> > From 77fdbe116be59ff111119ab23b62db90bcfa534e Mon Sep 17 00:00:00 2001
> > From: Mats Erik Andersson <address@hidden>
> > Date: Wed, 3 Nov 2010 09:34:17 +0100
> > Subject: [PATCH 2/2] src/inetd.c: Further conditions on AI_V4MAPPED.
> 
> > diff --git a/src/inetd.c b/src/inetd.c
> > index f5f7d32..ce7592e 100644
> > --- a/src/inetd.c
> > +++ b/src/inetd.c
> > @@ -743,7 +743,7 @@ inetd_getaddrinfo (struct servtab *sep, int proto, 
> > struct addrinfo **result)
> >  
> >    hints.ai_flags = AI_PASSIVE;
> >  #ifdef AI_V4MAPPED
> > -  if (sep->se_v4mapped)
> > +  if (sep->se_v4mapped && (sep->se_family != AF_INET))
> >      hints.ai_flags |= AI_V4MAPPED;
> >  #endif
> >    hints.ai_family = sep->se_family;
> 
> This is due to a regression introdocued with commit
> a12021ee959a88b48cd16e947c671f8f59e29c9d, although innocuous it should
> not be really needed, please see my reply to that thread.

Good to know. Still I will apply this particular change, since the test is
cheap and the mechanism clearly is needed for FreeBSD. Besides that, I did
get an ACK for a two-patch set where this is contained. Small victories!

Best regards,
Mats