Re: [bug-inetutils] syslogd - clog.patch - port clog from bsd version to inetutils linux

[Daniel Lehne]

On 30.11.2011 г. 16:53, Alfred M. Szmidt wrote:
>     The patch is not working because of the following reasons. The clog
>     tool is not included in build and the reasons are unkown. Changes
>     in inetutils-1.6/configure.ac are failed to achieve this. The
>     syslogd couldn't build because of missing clog.h in inetutils/lib,
>     assuming that clog.h automatically copied to inetutils-1.6/lib in
>     install process of clog. The syslogd depends on clog.
>
> Interesting!  We are currently rolling a release, so this will have to
> wait until after.  But we can get the ball rolling.  I think this
> would be a nicer feature, I did look for it once.
I look for it, because logrotate and other, are not the optimal solution 
for embedded targets.
>     Index: inetutils-1.6/clog/Makefile.am
>
> Since it is such a small program, it would be better to add it under
> src/.  The name clog is a bit bad, but if that is what the BSDs use
> then we should stick with it.
Clog is a standalone program, which add a special header to a new log 
file (prepare for syslogd). And such a special log file should read with 
the clog tool.
>     Index: inetutils-1.6/clog/clog.h
>     ===================================================================
>     --- /dev/null    1970-01-01 00:00:00.000000000 +0000
>     +++ inetutils-1.6/clog/clog.h    2011-11-30 10:49:18.769499826 +0200
>     @@ -0,0 +1,53 @@
>     +/*-
>     + * Copyright (c) 2001
>     + *     Jeff Wheelhouse (address@hidden)
>
> Do you know if Jeff Wheelhouse would like to sign an copyright
> assignment for this code?  Did you do any significant changes to this?
> Also, has anyone else done any such changes?  We would need everyone
> who has contributed any significant amount of code to assign (or
> disclaim) their copyright to the FSF before we can include this in
> inetutils.
I thougt it is with BSD liecense, so naming the designer and the 
liecense should be enough. I changed the source only to be compileable, 
without pointing to portable. Yes, the source is really old, but at 
least designed and available for AIX and FlyDragon. I have never 
contacted Mr. Wheelhouse.
>     Index: inetutils-1.6/syslogd/syslog.conf.5
>     Index: inetutils-1.6/clog/clog.8
>
> The documentation for inetutils is written in texinfo, so the relevant
> chapters would need to be added/updated if we are going to include
> this.
>
>
> Those are the major issues as it stands, if we can get the ball
> rolling on that then we can start discussing the code which has some
> issues (not using argp, BSD specific hackery which isn't portable,
> using static buffers for file names, etc).
I will be glad if the code will be reviewed and discussed, to bring it 
to the actual standards. But can you give me a hint how to include it in 
the package now, for a first testing step?

Thanks!