Re: [bug-inetutils] ftp: nmap mode is severely buggy

[Mats Erik Andersson]

lördag den 15 december 2012 klockan 16:31 skrev Mats Erik Andersson detta:
> Dear all,
> 
> in "ftp/cmds.c" the functions domap() and cp_subst() are
> causing infinite loops and segmentation faults, even
> segmentation faults during later use of history scrolling.
> 
> The legacy clients "ftp" in FreeBSD and OpenSolaris
> are correctly handling the cases below, so it is the
> modification of domap() calls and implementation
> for GNU Inetutils that compromise the code.
> 
>   ftp> nmap $1.$2 $1.[$2,txt]
> 
>   ftp> nmap $1.$2 $1.$2
> 
>   ftp> nmap $1.$2 $2.$1.new

I am surprised by the density of errors on this small matter,
one serious error and two grave errors within 140 line of code,
all caused by contributors to this project.

Corrections were just committed. A change made in 2009-12-03,
causing the present infinite loop, was clearly passed untested,
which highlights the necessity to test every "clever" change
attempted to old functional code.

Regards
  Mats E A