bug-librejs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-librejs] patch to support non-standard installs


From: Brandon Invergo
Subject: Re: [Bug-librejs] patch to support non-standard installs
Date: Fri, 02 Nov 2012 12:24:00 +0100
User-agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/24.2.1 (x86_64-unknown-linux-gnu)

> Wow! Thanks so much for your work! Now I have a good example to learn
> more Make and autoconf from!
> Very cool! I've ordered a hard copy of the Make manual from the FSF
> store and I'll keep adding up to this as I get a better
> understanding.

No problem, I'm happy to help! Better not learn from me, though, since
I'm still a bit of a Make/Autotools newbie myself. This was good
practice though. :)

I'm attaching a small patch for Makefile.in and configure.ac. All it
does is allow the user to specify some arguments to pass to cfx via the
environment variable CFX_ARGS. Because it affects configure.ac, you'll
have to run autoconf to generate a new configure file. 

Also, originally I had made a variable called "exthash" in Makefile.in
but now that I've been trying to get LibreJS to work with Conkeror, I've
learned that that hash represents Firefox, not the extension. I would
recommend renaming the variable to something like apphash and then open
the possibility of specifying which application to install the plugin
into. Something like this in Makefile.in:


    APP = firefox
    ifeq ($(APP),firefox)
         apphash = {aotnhuaonuhnaouhothuasoeusnouh}
    else ifeq ($(APP),conkeror)
         apphash = {sntaunstoesunaoeunsaohunseount}
    else ifeq ($(APP),fenrec)
         apphash = {soaenuhaotuhaonuhaoenuhuhasoen}
    endif
    extdir = ${libdir}/mozilla/extensions/${apphash}


And in configure.ac:


    AC_ARG_VAR([APP], \
         [the application for which to install LibreJS (default=firefox)])


But that's all completely untested so I leave it to you as a homework
assignment ;)

Let me know if you run into any problems!

-brandon




reply via email to

[Prev in Thread] Current Thread [Next in Thread]