Re: [Bug-librejs] LibreJS not detecting web labels

[Ruben Rodriguez]

On 09/06/2018 08:16 AM, Pelle Hjek wrote:
> Hi LibreJS bug list,
> 
> I'm working on a Hacker News fork ( https://notabug.org/arc/knark ) where I'm 
> trying to add license labels for LibreJS.
> 
> * I've added JavaScript web labels as described here: 
> https://www.gnu.org/software/librejs/free-your-javascript.html
> * I've confirmed that the license link and title matches one given here: 
> https://www.gnu.org/software/librejs/manual/html_node/Free-Licenses-Detection.html#Free-Licenses-Detection
> * I can observe from the REPL of this HN-like web app that LibreJS *is* 
> indeed fetching the web labels license table
> 
> Yet LibreJS complains that the script in question, `news.js`, is "External 
> script with no known license."
> 
> 
> So, this is perhaps a LibreJS bug, no? Regardless, it would be nice if 
> LibreJS would be a little bit more specific and/or verbose in its reasons for 
> blocking scripts, or at least have an option to enable this.  Or maybe 
> LibreJS already has a debug/verbose mode that I just haven't been able to 
> find?

If you run the browser with -jsconsole you should see a message if
weblabels fail to be loaded.

There is a debug mode but you have to enable it in the code and build
the xpi with it. I'll see about having that be a user setting instead.


> 
> For reference, the web labels table page looks like this, (and yes, the table 
> is included before the <script> tag loading `news.js`):

Where you put the link to the weblabels page does not matter. How does
the link itself look like (the code)?

> <table id="jslicense-labels1"><tr><td><a 
> href="news.js">news.js</a></td></tr><tr><td><a 
> href="http://www.perlfoundation.org/artistic_license_2_0";>Artistic License 
> 2.0</a></td><td><tr><td><a 
> href="news.js">news.js</a></td></tr></td></tr></table>

That looks ok. Is it wrapped in valid html headers and such?


-- 
Ruben Rodriguez | Senior Systems Administrator, Free Software Foundation
GPG Key: 05EF 1D2F FE61 747D 1FC8  27C3 7FAC 7D26 472F 4409
https://fsf.org | https://gnu.org

signature.asc
Description: OpenPGP digital signature