bug-librejs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] fixing internal public domain script recognition.


From: Yuchen Pei
Subject: [PATCH] fixing internal public domain script recognition.
Date: Wed, 25 Aug 2021 16:01:06 +1000
User-agent: mu4e 1.4.13; emacs 27.2


Yuchen Pei <hi@ypei.me> writes:

Hello,

Here's an example:

https://www.john2x.com/blog/blogging-with-orgmode.html

<SCRIPT> at line 197 of
https://www.john2x.com/blog/blogging-with-orgmode.html:

NONTRIVIAL: nontrivial token: 'document'

Here's the offending script, which is labeled public domain per the
guidelines at
https://www.gnu.org/software/librejs/free-your-javascript.html (Seciont 3.2.2):

<script type="text/javascript">
// @license
magnet:?xt=urn:btih:e95b018ef3580986a04669f1b5879592219e2a7a&dn=public-domain.txt Public Domain
<!--/*--><![CDATA[/*><!--*/
    function CodeHighlightOn(elem, id)
    {
      var target = document.getElementById(id);
      if(null != target) {
        elem.classList.add("code-highlighted");
        target.classList.add("code-highlighted");
      }
    }
    function CodeHighlightOff(elem, id)
    {
      var target = document.getElementById(id);
      if(null != target) {
        elem.classList.remove("code-highlighted");
        target.classList.remove("code-highlighted");
      }
    }
   /*]]>*///-->
// @license-end
</script>

Best,
Yuchen

The following patch seems to fix it (the identifier is "PublicDomain" not "Public Domain", i.e. without space).

Can someone review it?

From 30afa9c9de609b1e1e1b1fc47f7464ed642935c9 Mon Sep 17 00:00:00 2001
From: Yuchen Pei <hi@ypei.me>
Date: Wed, 25 Aug 2021 15:57:14 +1000
Subject: [PATCH] fixing internal public domain script recognition.

using the camelcase convention ("PublicDomain") in licenses.json.
---
 licenses.json | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/licenses.json b/licenses.json
index 875e676..edea147 100644
--- a/licenses.json
+++ b/licenses.json
@@ -180,6 +180,11 @@
                        "URL": "http://www.mozilla.org/MPL/2.0";,
                        "Magnet link": 
"magnet:?xt=urn:btih:3877d6d54b3accd4bc32f8a48bf32ebc0901502a&dn=mpl-2.0.txt"
                },
+               "PublicDomain":{
+                       "Name": "Public Domain",
+                       "URL": "",
+                       "Magnet link": 
"magnet:?xt=urn:btih:e95b018ef3580986a04669f1b5879592219e2a7a&dn=public-domain.txt"
+               },
                "UPL-1.0": {
                        "Name": "UPL 1.0",
                        "URL": "https://oss.oracle.com/licenses/upl/";,
-- 
2.33.0



--
Best,
Yuchen

PGP Key: 47F9 D050 1E11 8879 9040  4941 2126 7E93 EF86 DFD0
          <https://ypei.me/assets/ypei-pubkey.txt>

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]