Re: LibreJS webextension - i'd like to help as JS developer

[Egor Klenin]

HI, about JS->TS conversion, I just thought it's good idea to allow 
using Typescript. If configured not too strictly, it has almost no 
difference from JS, but it's allow to use types when necessary, and also 
there is a lot of ready type packages in NPM registry.

I implemented only partial conversion, because there is some files I was 
not able to refactor to TS (there was some issues with JS modules 
importing in some cases, I didn't figured out why). And also that kind 
of configuration allows to work JS code, it may be useful in case when 
some developer is not familiar with TS.

On 1/12/22 10:58, Yuchen Pei wrote:
> Hi Egor,
>
> > > I've tried to build and run extension from
> > > sources at localhost. I  configured linting, TypeScript compiling and
> > > live-reloading of sources. You can review this changes here
> > > https://github.com/e-g1gor/librejs-refactoring-fork What changed
> > > exactly
> > > is explained here
> > > https://github.com/e-g1gor/librejs-refactoring-fork/blob/refactor-
> > > project-configuration/CHANGES_README.md
> Thanks for the refacotring work you have done.  I don't have much
> bandwidth atm but I'll let you know if I have any feedback on your
> changes or want to integrate any of them once I've gone through them.
> Meanwhile feel free to discuss here at librejs mailing list, which is
> the main channel of communication about the development.
>
> One quick question: could you explain a bit more about the rationale of
> these changes, for example, why did you do the partial JS->TS
> conversion?
>
> Best,
> Yuchen

OpenPGP_0x00CF380617A15BF0.asc
Description: OpenPGP public key

OpenPGP_signature
Description: OpenPGP digital signature