[MLB] Something strange in the land of MAGIC_CMD

[Raja R Harinath]

Hi,

I recently updated to the latest 'multi-lang-branch' version of
libtool.  While building on i686-pc-linux-gnu, I found the following
strange invocation:

  rm -f libtoolT
  AR="ar" CC="gcc" CFLAGS="" CPPFLAGS="" \
  LTCC="gcc" FILE="" LD="/home/grad04/harinath/linux/i686-pc-linux-gnu/bin/ld" 
LDFLAGS="" \
  LIBS="" LN_S="ln -s" NM="/home/grad04/harinath/linux/bin/nm -B" 
RANLIB="ranlib" \
  STRIP="strip" AS="" DLLTOOL="" \
  OBJDUMP="" \
  objext="o" exeext="" \
  reload_flag="-r" \
  deplibs_check_method="pass_all" \
  file_magic_cmd="AGIC_CMD" \
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  /bin/sh ../../ltconfig --cache-file=./config.cache --with-gcc --with-gnu-ld 
--enable-dlopen --srcdir=../.. \
    --output=libtoolT ../../ltmain.sh i686-pc-linux-gnu

Note the line

   file_magic_cmd="AGIC_CMD"

I checked the Makefile, it had a line that looks like:

   file_magic_cmd = $MAGIC_COMMAND

which in turn is used in the 'libtool' target:

   file_magic_cmd="$(file_magic_cmd)" ... ltconfig ...

No wonder.

I tried the following, and it "worked", but since I'm not familiar
with what's going on in there, I'm not sure if this is the right fix.
Also, since I don't have a 'file_magic' machine, I can't verify that
the above is actually a problem.

  Index: configure.in
  ===================================================================
  RCS file: /home/cvs/libtool/configure.in,v
  retrieving revision 1.38.2.10
  diff -u -p -u -r1.38.2.10 configure.in
  --- configure.in        2000/09/03 21:45:01     1.38.2.10
  +++ configure.in        2000/10/10 22:08:39
  @@ -49,6 +49,7 @@ AC_SUBST(DLLTOOL)
   AC_SUBST(FILE)
   AC_SUBST(OBJDUMP)
   AC_SUBST(AS)
  +AC_SUBST(MAGIC_COMMAND)
   AC_SUBST(reload_flag)
   AC_SUBST(file_magic_cmd)
   AC_SUBST(deplibs_check_method)
  Index: libtool.m4
  ===================================================================
  RCS file: /home/cvs/libtool/libtool.m4,v
  retrieving revision 1.71.2.36
  diff -u -p -u -r1.71.2.36 libtool.m4
  --- libtool.m4  2000/10/10 05:00:18     1.71.2.36
  +++ libtool.m4  2000/10/10 22:08:39
  @@ -104,7 +104,7 @@ dnl
   # Only perform the check for file, if the check method requires it
   case "$deplibs_check_method" in
   file_magic*)
  -  if test "$file_magic_cmd" = '$MAGIC_CMD'; then
  +  if test "$file_magic_cmd" = '${MAGIC_CMD}'; then
       AC_PATH_MAGIC
     fi
     ;;
  @@ -497,7 +497,7 @@ test -n "$reload_flag" && reload_flag=" 
   AC_DEFUN(AC_DEPLIBS_CHECK_METHOD,
   [AC_CACHE_CHECK([how to recognise dependant libraries],
   lt_cv_deplibs_check_method,
  -[lt_cv_file_magic_cmd='$MAGIC_CMD'
  +[lt_cv_file_magic_cmd='${MAGIC_CMD}'
   lt_cv_file_magic_test_file=
   lt_cv_deplibs_check_method='unknown'
   # Need to set the preceding variable on all platforms that support

- Hari
-- 
Raja R Harinath ------------------------------ address@hidden
"When all else fails, read the instructions."      -- Cahn's Axiom
"Our policy is, when in doubt, do the right thing."   -- Roy L Ash