Re: Who is going to fix libtool-1.5 bug in cvs?

[Martin MOKREJŠ]

On Wed, 21 May 2003, Robert Boehne wrote:

Hi Robert,
  I'll try to do my best. :)

> Martin,
>
> Complaints are not nearly as effective as sending a patch
> in the proper format.  I've seen quite a few of these patches
> in context diff format and against some ancient version and to
> the wrong list (I've only recently subscribed to bug-libtool).
> I do not have time for this extra work, and if I don't get a
> patch in the format (which you can find at
> http://www.gnu.org/software/libtool/contribute.html )
> I do not have much sympathy for the people who posted it.
>   However, if the patch posting *clearly* shows that there is
> a problem in Libtool I will generally take the trouble to
> fix it.  The patch you referr to has an explanation that
> doesn't seem to have anything to do with the patch.  It goes
> on about aclocal.m4 being too large, having the wrong libtool.m4
> in certain cases, etc. but nothing to explain how AC_PROG_EGREP

But why didn't you ask Bruno to make it clearer? I cannot explain
much of the details, it just happened I faced a problem with
gettext/autogen.sh doing weird things. And Bruno found the reason
in libtool-1.5. I believe he'll send you more comments on that
if you wish.

> is the cause of any of it.  More important to me that having
> no bugs in Libtool is that we all learn why any piece of code
> is "bad".  I don't find it very interesting or responsible to
> blindly apply patches that I don't understand or see a reason for.
>   Three rules to get your patches applied:
> 1) post them to the correct list in the correct format
> 2) explain the problem
> 3) explain how the patch fixes it

cvs server: Diffing .
Index: libtool.m4
===================================================================
RCS file: /cvsroot/libtool/libtool/libtool.m4,v
retrieving revision 1.319
diff -u -r1.319 libtool.m4
--- libtool.m4  21 May 2003 04:45:25 -0000      1.319
+++ libtool.m4  21 May 2003 15:17:52 -0000
@@ -1851,7 +1851,7 @@
 # -------------
 # This is predefined starting with Autoconf 2.54, so this conditional
 # definition can be removed once we require Autoconf 2.54 or later.
-m4_ifndef([AC_PROG_EGREP], [AC_DEFUN([AC_PROG_EGREP],
+m4_ifndef([AC_PROG_EGREP], [AC_DEFUN([AC_][PROG_EGREP],
 [AC_CACHE_CHECK([for egrep], [ac_cv_prog_egrep],
    [if echo a | (grep -E '(a|b)') >/dev/null 2>&1
     then ac_cv_prog_egrep='grep -E'


>
> Best yet, submit a new testcase that your patch fixes.

The above patch works for me here, i.e. all tests except the quote.test
test PASS (before this fix many of them failed, if I remember right).
Regarding the quote test - somehow the single quote fails. I'll try to post
a report, but am not how to get some details out of that specific test.
Would you help? Thanks!
Martin

> Robert
>
> Martin MOKREJ? wrote:
> >
> > Hi,
> >   in April Bruno Haible found a bug in libtool-1.5. See the message at
> > http://mail.gnu.org/archive/html/libtool-patches/2003-04/msg00068.html
> > Why isn't this still fixed in cvs and why isn't there a new release with
> > this terrible bug fixed?
> >
> >   This is how I obtained my cvs copy:
> >
> > cvs -d :pserver:address@hidden:/cvsroot/libtool -z6 co libtool
> >
> > --
> > Martin Mokrejs <address@hidden>, <address@hidden>
> > PGP5.0i key is at http://www.natur.cuni.cz/~mmokrejs
> > MIPS / Institute for Bioinformatics <http://mips.gsf.de>
> > GSF - National Research Center for Environment and Health
> > Ingolstaedter Landstrasse 1, D-85764 Neuherberg, Germany
> > tel.: +49-89-3187 3683 , fax: +49-89-3187 3585
> >
> > _______________________________________________
> > Bug-libtool mailing list
> > address@hidden
> > http://mail.gnu.org/mailman/listinfo/bug-libtool
>

-- 
Martin Mokrejs <address@hidden>, <address@hidden>
PGP5.0i key is at http://www.natur.cuni.cz/~mmokrejs
MIPS / Institute for Bioinformatics <http://mips.gsf.de>
GSF - National Research Center for Environment and Health
Ingolstaedter Landstrasse 1, D-85764 Neuherberg, Germany
tel.: +49-89-3187 3683 , fax: +49-89-3187 3585