[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] VPATH build of Libtool

From: Ralf Wildenhues
Subject: [PATCH] VPATH build of Libtool
Date: Mon, 26 Jan 2004 21:56:05 +0100
User-agent: Mutt/

A VPATH build shows a few inconsistencies and bugs:

config.h is created in $builddir, not $srcdir, affecting
ltdl.lo dependency.  In libltdl/Makefile.am,
| AM_CPPFLAGS = -I$(top_srcdir)

should be unnessecary (there is no file to include from there),
since automake adds -I$(top_builddir) to DEFAULT_INCLUDES.
Patch for both below.

I'm unsure about config/ltmain.sh, its handling is not consistent
as of now.  Should it be created in the source or the build tree?
- configure creates it in $top_builddir/config/ltmain.sh
- `make dist' fails because it does not find it in the source tree:

| make[2]: Entering directory `/home/ralf/lt/test-vpath/build/tests/cdemo'
| make[2]: *** No rule to make target 
`/home/ralf/lt/test-vpath/libtool/tests/cdemo/../../config/ltmain.sh', needed 
by `distdir'.  Stop.
| make[2]: Leaving directory `/home/ralf/lt/test-vpath/build/tests/cdemo'


2004-01-25  Ralf Wildenhues  <address@hidden>

        * libltdl/Makefile.am: config.h is created in $(top_builddir),
        not $(top_srcdir).

Index: libltdl/Makefile.am
RCS file: /cvsroot/libtool/libtool/libltdl/Makefile.am,v
retrieving revision 1.46
diff -u -r1.46 Makefile.am
--- libltdl/Makefile.am 22 Jan 2004 22:25:43 -0000      1.46
+++ libltdl/Makefile.am 26 Jan 2004 20:54:28 -0000
@@ -19,7 +19,6 @@
 AUTOMAKE_OPTIONS = no-dependencies foreign
-AM_CPPFLAGS = -I$(top_srcdir)
@@ -45,7 +44,7 @@
 libltdlc_la_LIBADD = $(LIBADD_DL)
 ## Because we do not have automatic dependency tracking:
-ltdl.lo: ltdl.h $(top_srcdir)/$(CONFIG_H)
+ltdl.lo: ltdl.h $(top_builddir)/$(CONFIG_H)
 ## These are installed as a subdirectory of pkgdatadir so that

reply via email to

[Prev in Thread] Current Thread [Next in Thread]